Add Project model for chants & return segment to a source-level object
#1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove segment field from chants and sequences Add project field to chants and sequences
The assign_sequences_to_bower_project command fills in the new project field on sequences with the Clavis Sequentiarum project. Also, creates relevant test.
lucasmarchd01
requested changes
Jun 21, 2024
|
Thanks for taking a look! Yeah, I’ve been meaning to get to the tests. I’ll figure those out and alert you if it means anything substantive has to change. |
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1541. Removes the
segmentfield from theBaseChantmodel. With this PR,segmentreturns to a property of sources, not changes.Closes #1542. Adds the
Projectmodel and theprojectfield as a foreign key onBaseChant. A chant'sprojectcan be used to designate that it is part of a particular inventorying project or to designate that certain specific fields are relevant to that chant (for example, chants in the "Benedicamus Domino" project have additional fields shown on the Chant Create and Chant Edit pages. Functionality for special Benedicamus Domino fields that had been commented out in #1521 have been restored. Modifies test functions, includingmake_fake_chantto reflect this change.This PR also add the
assign_sequences_to_bower_projectcommand to assign existingSequences to the "Clavis Sequentiarum" project. It removes theassign_chants_to_segmentscommand as no longer necessary. Relevant tests are added and removed respectively for these commands.NOTE: The two current projects, "Clavis Sequentiarum" and "Benedicamus Domino", require manually adding these projects through the Admin panel before
Chants can be assigned to those projects.While I was thinking about sequences, also closes #1544.